Remove package-lock.json file #558
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No files changed ☑️ |
|
Hello @mschrage,
Please add a 👍 as a reaction to this comment to show that you read this. |
fedeci
approved these changes
Sep 3, 2021
QuiiBz
approved these changes
Sep 5, 2021
|
Closing in favor of #575 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know we always oscillate on this but should we get rid of the package-lock.json? There is a new contributor who is trying to make a PR and is getting stuck on this. #546
Also Sindresorhus says Lockfiles for apps, not packages. See his thoughts here: sindresorhus/ama#479 (comment)
I'm not sure if the lockfile is actually giving us very much, since the only dependencies that withfig/autocomplete has are devDependencies, like husky, eslint and tsc.